Circular dependency (equalTo and notEqualTo)

[kirilmitev]

Lets say we have the "confirm password" situation - we have 2 form controls, password1 and password2, which should contain the same value. We might want to add the "equalTo"-validator to both controls, so that the "equalTo" error is attached to both of them. in their control.errors Array. This situation causes a circular dependency between the controls, as updating the value of one control updates the other, which in turn updates again the first control and so on.

I'll create a pull request for this shortly.

[rsaenen]

Hi,
As no one answer, merge or update this repository, I forked it and fixed circular dependencies, build errors.
Can you make a PR on my branch ?

[kirilmitev]

Hey Ralf, I'm sorry for the late answer, these past few weeks are crazy stressful, I had a lot to do. So, I was also thinking of extending the work of YuYang, as it is a very needed functionality, but I was waiting till I get a little more free time. I see you have called your branch "ng4-validators", I was thinking, maybe rename it in "ng-validation" and maintain support for the newest Angular version (v5 at the moment). What do you think? Regarding your question about making a pull request on your branch, you already fixed the circular dependency problem, so what changes do you want me to push? Best regards Kiril

…

________________________________ Von: Ralf Saenen <[email protected]> Gesendet: Donnerstag, 12. Oktober 2017 15:02:15 An: yuyang041060120/ng2-validation Cc: Mitev, Kiril; Author Betreff: Re: [yuyang041060120/ng2-validation] Circular dependency (equalTo and notEqualTo) (#95) Hi, As no one answer, merge or update this repository, I forked it and fixed circular dependencies, build errors. Can you make a PR on my branch ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#95 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/APqvjJdDyswO-lQiKIn1kbvAXkGGAIv1ks5srg3XgaJpZM4OGiXj>.