Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncplay-android often can't find file in playlist if it's put in subdirectory under media directory #54

Closed
soredake opened this issue Feb 25, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@soredake
Copy link

soredake commented Feb 25, 2023

If i put "/directory" into media directories list, and the put some files into "/directory/subdirectory" and add this files to playlist syncplay-android will have troubles finding them most of the time.

@yuroyami yuroyami self-assigned this Feb 25, 2023
@yuroyami yuroyami added the bug Something isn't working label Feb 25, 2023
@yuroyami
Copy link
Owner

yuroyami commented Feb 25, 2023

It does fail to get files sometimes which is why I'm rewriting it for the moment, also, there will be a new feature that requires the user to turn on 'All files access', to not need media directories anymore, and the app will then query the entire device instead. Given the fact that most devices are fast enough storage-wise, it will be a good alternative to manually adding media directories.

@soredake
Copy link
Author

Given the fact that most devices are fast enough storage-wise,

Don't know about microsd cards with large amount of folders/files like mine.

@yuroyami
Copy link
Owner

yuroyami commented Feb 26, 2023

@soredake It will be optional and not enforced, so media directories will always be a thing, to account for low-end devices and secondary storage like yours

Btw, does this issue happen when you're loading files from the main storage ? this might have sth to do with only secondary storages etc

Also, how often does it happen?

@soredake
Copy link
Author

Btw, does this issue happen when you're loading files from the main storage ?

It seems not, tried several adding several files from internal storage, all loaded fine.

this might have sth to do with only secondary storages etc

I discovered reason why file is not loading, if i join room with only one playlist item it will not load from internal storage or microsd, adding another file to playlist and switching files makes first playlist item load fine until restart.

@yuroyami
Copy link
Owner

Noted, thanks for the troubleshooting

@soredake
Copy link
Author

Also this bug makes me unable to switch playlist items, it will just stay on currently open file, even if i remove this playlist item.

@yuroyami
Copy link
Owner

@soredake, revamping broke many stuff, i will revisit the whole shared playlist thing since i just decided to perform a complete re-write on it. Thanks for bringing this to light

@soredake soredake changed the title Syncplay-android often can't find file in playlist Syncplay-android often can't find file in playlist if it's put in subdirectory in media directory May 26, 2023
@soredake soredake changed the title Syncplay-android often can't find file in playlist if it's put in subdirectory in media directory Syncplay-android often can't find file in playlist if it's put in subdirectory under media directory May 26, 2023
@soredake
Copy link
Author

I've updated issue title and description.

@yuroyami
Copy link
Owner

Though shared playlists are still "incubating" and unstable, the whole tree inside a media directory is searched in v0.14.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants