Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--ci-config misplaced #194

Open
pindge opened this issue May 28, 2021 · 3 comments · May be fixed by #373
Open

--ci-config misplaced #194

pindge opened this issue May 28, 2021 · 3 comments · May be fixed by #373

Comments

@pindge
Copy link

pindge commented May 28, 2021 

Digest: sha256:2d3be9e9362ecdcb04bf3afdd402a785b877e3bcca3d2fc6e10a83d99ce0955f
Status: Downloaded newer image for wagoodman/dive:v0.9
docker.io/wagoodman/dive:v0.9
/usr/bin/docker run -e CI=true -e DOCKER_API_VERSION=1.37 --rm -v /var/run/docker.sock:/var/run/docker.sock --mount type=bind,source=/home/runner/work/datacube-ows/datacube-ows/dive-ci.yml,target=/.dive-ci --ci-config /.dive-ci wagoodman/dive:v0.9 ${ORG}/${IMAGE}:_builder
unknown flag: --ci-config
See 'docker run --help'.

https://github.com/opendatacube/datacube-ows/pull/613/checks?check_run_id=2691139167'

It is returning error for us, I believe the tag --ci-config is misplaced, it should be placed after wagoodman/div:v0.9 instead of before
@whatnick
Copy link

These variables need to placed after the diveImage parameter since they are parameters being sent to the dive command within the dive docker image rather that docker cli itself.

@nwmcsween
Copy link

see #204

@wildone
Copy link

wildone commented Feb 25, 2022 •
edited
Loading

update config-file: ${{ github.workspace }}/.dive-ci.yml to use ${{ env.GITHUB_WORKSPACE }}

  - name: Run docker image analysis
    uses: yuichielectric/[email protected]
    with:
      image: ${{ env.IMAGE }}:${{ env.GIT_BRANCH }}
      config-file: ${{ env.GITHUB_WORKSPACE }}/.dive-ci.yml
      github-token: ${{ secrets.GITHUB_TOKEN }}

@MaxymVlasov MaxymVlasov linked a pull request Apr 16, 2022 that will close this issue
Open
@MaxymVlasov MaxymVlasov mentioned this issue Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump dive image version to 0.12, fix --ci-config and other issues MaxymVlasov/dive-action
4 participants
@wildone @whatnick @nwmcsween @pindge