Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django test suite issues with YB as backend #7760

Closed
hbhanawat opened this issue Mar 23, 2021 · 2 comments
Closed

Django test suite issues with YB as backend #7760

hbhanawat opened this issue Mar 23, 2021 · 2 comments
Assignees
Labels
area/ecosystem Label for all ecosystem related projects kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@hbhanawat
Copy link
Contributor

hbhanawat commented Mar 23, 2021

Jira Link: DB-2557
Currently Django test suite fails with YB as backend. One of the issue that we encounter is because the way savepoints are implemented. The issues are reported here:
https://code.djangoproject.com/ticket/28263
https://code.djangoproject.com/ticket/32527

However these issues are overcome by overriding the savepoint function in the Django backend for YB.

The another issue is that the tests fail because the tests rely extensively on savepoints to do data validations. Django tests create savepoints before the start of test and do a rollback at the end. Since, savepoint is a no-op with YB backend, we see data mis match issues.

Once savepoints are supported ( #4415) then we can start fixing the issues.

@hbhanawat hbhanawat added the area/ecosystem Label for all ecosystem related projects label Mar 23, 2021
@kneeraj
Copy link
Contributor

kneeraj commented Nov 18, 2021

@Sfurti-yb please close the ticket as soon as we release the doc as we have tested the new savepoint feature does work with YugabyteDB

@Sfurti-yb
Copy link
Contributor

Sfurti-yb commented Dec 2, 2021

On reverting the savepoint changes made to the Django backend for YB and re-running the test suite, database shutdown issues were faced for some test modules. The issue is reported here: #10765
The tests generating the shutdown error passed when run individually.

@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ecosystem Label for all ecosystem related projects kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

4 participants