Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] [xCluster] ALTER DDL Abort #13649

Open
nspiegelberg opened this issue Aug 16, 2022 · 0 comments
Open

[DocDB] [xCluster] ALTER DDL Abort #13649

nspiegelberg opened this issue Aug 16, 2022 · 0 comments
Assignees
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@nspiegelberg
Copy link
Contributor

nspiegelberg commented Aug 16, 2022

Jira Link: DB-3214

Description

When a DDL is aborted late in the transaction apply phase, we can run into a situation where the META_OP for the ALTER has been persisted in the WAL logs. The Abort happens and, with #13358, a second META_OP is written to undo the operation. This is sufficient for the single cluster use case. However, XCluster will consume this log entry and can possibly halt waiting for user-initiated synchronization (#11017).

A couple high level design options:

  1. Persist the Transaction ID with the META_OP. We will soon replication the Transaction Status table, so the Consumer Master can consult that to understand if this is related to a committed transaction or one that is rolled back.
  2. Inspect the contents of packets after the META_OP and only halt if an unsupported Column is used. This wouldn't happen during an Abort situation.

#2 seems like it might have a lot of performance complications and make the halting logic more complex. #1 seems more aligned with the existing design patterns for XCluster.

@nspiegelberg nspiegelberg added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Aug 16, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue and removed status/awaiting-triage Issue awaiting triage labels Aug 16, 2022
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants