Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1st month of the year doesn't aligned with Year start #4

Open
dernasherbrezon opened this issue Dec 25, 2016 · 9 comments
Open

1st month of the year doesn't aligned with Year start #4

dernasherbrezon opened this issue Dec 25, 2016 · 9 comments

Comments

@dernasherbrezon
Copy link

Steps to reproduce:

  1. Open diagram
  2. Click view -> zoom in (ctrl + or cmd +)
  3. See screenshot for artifact

screen shot 2016-12-19 at 2 36 09 pm

@yucatio
Copy link
Owner

yucatio commented Dec 26, 2016

Yes, it is known issue.
taitems#51
Many problem happen when browser zooming.

It hard to fix this issue. Because we are using div and image as grid.
Using canvas or svg may solve this issue, but it takes too much work.

@KingGeneral
Copy link

what make it unsync is the width from the month,
Week change range : 52 - 53 (total week a year).

image

@yucatio
Copy link
Owner

yucatio commented Dec 27, 2016

Is it the difference between specify width by style="32px" and by css file?
In that case, I can fix the issue.

@dernasherbrezon
Copy link
Author

I think it's something related to css border. On different zoom levels border could be 0.5 or 0.7 even if it's specified in css as 1px.

@KingGeneral
Copy link

KingGeneral commented Dec 28, 2016

changing the max-width via css wont solve this issue, as the user zoom(+/-) ,
month max-width is different in every Scale,

maybe customable via code can do (max-width)??? (hard math calculation)
like what it do in Scale : 'days'

@yucatio
Copy link
Owner

yucatio commented Dec 28, 2016

In my environment (Google Chrome),
when zooming, months and grid are well aligned.
screencapture-yucatio-github-io-jquery-gantt-index-html-1482916722006
So I suggested to use style="width:32px" for each day div.
But your environment, day and gird are aligned.
Which browser you are using?
Anyway, it seems hard to fix without throughout version up.

@KingGeneral
Copy link

KingGeneral commented Dec 29, 2016

OS : windows 10, i5, intel HD grahpics
page : yucatio.github.io/jQuery.Gantt/

I do test with newest opera,edge,mozila,chrome
Tested at resolution :
1360x768, 1280x768, 1280x720, 1280x600, 1024x768, 800x600

PS : all scale is fine, exception for scale in weeks it is fail. (see attachment image)

chart test

@yucatio
Copy link
Owner

yucatio commented Jan 1, 2017

@KingGeneral
Week scale works fine. It is natural that year and month ends middle of week.
We are talking about browser zoom, not gantt zoom function.

@KingGeneral
Copy link

KingGeneral commented Jan 10, 2017

FYI there's a fix by @usmonster in taitems#213 and taitems#214 but might be a bit hard to applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants