From aa5847720f38b8b8d92641a9a19c5f1b531f6e12 Mon Sep 17 00:00:00 2001 From: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Date: Thu, 14 Mar 2024 17:01:46 -0700 Subject: [PATCH] Match flytekit versions used to register and run functional tests (#5059) * wip - test Signed-off-by: Eduardo Apolinario * Use latest flytekit to register tests Signed-off-by: Eduardo Apolinario * Use python 3.12 to run tests Signed-off-by: Eduardo Apolinario * Force versions of flytekit and image to match Signed-off-by: Eduardo Apolinario * Use awk Signed-off-by: Eduardo Apolinario * Checkout specific flytesnacks ref Signed-off-by: Eduardo Apolinario --------- Signed-off-by: Eduardo Apolinario Co-authored-by: Eduardo Apolinario --- .github/workflows/single-binary.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/single-binary.yml b/.github/workflows/single-binary.yml index 9a2c19a52c5..793a08e01b9 100644 --- a/.github/workflows/single-binary.yml +++ b/.github/workflows/single-binary.yml @@ -156,7 +156,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v4 with: - python-version: "3.11" + python-version: "3.12" - uses: unionai/flytectl-setup-action@v0.0.1 - name: Setup sandbox run: | @@ -181,17 +181,17 @@ jobs: with: repository: flyteorg/flytesnacks path: flytesnacks - # TODO: Enable this once refactored version produces a release tag - # ref: ${{ env.FLYTESNACKS_VERSION }} + ref: ${{ env.FLYTESNACKS_VERSION }} - name: Register specific tests run: | + flytekit_version=$(pip show flytekit | grep -i version | awk '{ print $2 }') while read -r line; do pyflyte --config ./boilerplate/flyte/end2end/functional-test-config.yaml \ register \ --project flytesnacks \ --domain development \ - --image cr.flyte.org/flyteorg/flytekit:py3.11-latest \ + --image cr.flyte.org/flyteorg/flytekit:py3.12-${flytekit_version} \ --version ${{ env.FLYTESNACKS_VERSION }} \ flytesnacks/$line; done < flytesnacks/flyte_tests.txt