Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logging anchor profiling by default in ytop #348

Open
l0kix2 opened this issue Sep 30, 2024 · 1 comment
Open

Enable logging anchor profiling by default in ytop #348

l0kix2 opened this issue Sep 30, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@l0kix2
Copy link
Collaborator

l0kix2 commented Sep 30, 2024

Until this hasn't been done in the server-side ytsaurus/ytsaurus#868

  • new (*bool please) option should be added in some part of the ytsaurus shared between the components related to logging (maybe here https://github.com/ytsaurus/yt-k8s-operator/blob/c439d7c703365a3d87827cc0bd3f0ac368eaa05d/api/v1/ytsaurus_types.go#L162-L162)
  • enable_anchor_profiling should be set in the logging section of static config for every component according to the new spec field (%true if filed value is nil or true) by adding a field with yson tag in some struct of config generators (somewhere around here)
  • it is expected all config tests canondata will expectedly fail since new field is added with default, so they need to be re-canonized (there should be env var for that)
  • add confgi generator test for the false behaviour
removed we can configure it in ytop like that: ``` yt set //sys/scheduler/config/logging '{enable_anchor_profiling=%true}' yt set //sys/controller_agents/config/logging '{enable_anchor_profiling=%true}' yt set //sys/@config/cell_master/logging '{enable_anchor_profiling=%true}' yt set //sys/cluster_nodes/@config/exe/logging '{enable_anchor_profiling=%true}' yt set //sys/cluster_nodes/@config/dat/logging '{enable_anchor_profiling=%true}' yt set //sys/cluster_nodes/@config/tab/logging '{enable_anchor_profiling=%true}' yt set //sys/http_proxies/@config '{logging={enable_anchor_profiling=%true}}' yt set //sys/rpc_proxies/@config '{logging={enable_anchor_profiling=%true}}' yt set //sys/queue_agents/config/logging '{enable_anchor_profiling=%true}' yt set //sys/query_tracker/config '{logging={enable_anchor_profiling=%true}}' ```
@zlobober
Copy link
Contributor

Correction - it should not be done like that by operator. The snippet from the issue is a way to set these options via dynamic config, but they are also easily configurable on a level of static config, and we generally adhere to setting static config from ytop, not the dynamic one.

@l0kix2 l0kix2 added the good first issue Good for newcomers label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants