[blick] Add new extractor (blick.ch is a swiss newspaper platform, wh… #9598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich provides also videos)
| video_id = mobj.group('id') | ||
| webpage = self._download_webpage(url, video_id) | ||
|
|
||
| found_videos_og = re.findall(r'<meta.*?property="og:video".*?content="(.*?)"', webpage) |
There was a problem hiding this comment.
Have you checked out _og_search_property?
There was a problem hiding this comment.
_og_search_video_url may be even better.
Sorry _og_search_video_url can't be applied for re.findall, while _og_regexes is still useful.
There was a problem hiding this comment.
I'm using now _og_regexes to do this.
| found_videos = [] | ||
| regex_og = self._og_regexes('video') | ||
| regex_ogs = self._og_regexes('video:secure_url') | ||
| video_og = self._html_search_regex(regex_og, webpage, name=None, default=None, fatal=False) |
There was a problem hiding this comment.
default=None implies fatal=False.
- Use _match_id to get the video_id
- Extract the video title from the webpage instead of the url
- Removed unnecessary "if entry_info_dict.get('formats'):" check
…e for multiple version of the video.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ich provides also videos)