Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Funimation] allow for URLs with language codes #28972

Closed
wants to merge 2 commits into from

Conversation

Mevious
Copy link

@Mevious Mevious commented May 4, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This is a follow up to #28950. This fixes #28879. Funimation recently made an update to include the two-letter language code in URLs. This change allows the new URL format in addition to the old one. The old format does not work for me (see output below) so the unit tests fail for me. Apparently they work for others so I left them as is.

[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'--skip-download', u'https://www.funimation.com/shows/hacksign/role-play/']
[debug] Encodings: locale cp1252, fs mbcs, out UTF-8, pref cp1252
[debug] youtube-dl version 2021.04.26
[debug] Python version 2.7.17 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg git-2020-04-17-889ad93, ffprobe git-2020-04-17-889ad93
[debug] Proxy map: {}
[Funimation] role-play: Downloading webpage
WARNING: [Funimation] role-play: Failed to parse JSON No JSON object could be decoded
ERROR: Unable to extract al:web:url; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\Nasir\source\repos\youtube-dl-1\youtube_dl\YoutubeDL.py", line 806, in wrapper
    return func(self, *args, **kwargs)
  File "C:\Users\Nasir\source\repos\youtube-dl-1\youtube_dl\YoutubeDL.py", line 827, in __extract_info
    ie_result = ie.extract(url)
  File "C:\Users\Nasir\source\repos\youtube-dl-1\youtube_dl\extractor\common.py", line 534, in extract
    ie_result = self._real_extract(url)
  File "C:\Users\Nasir\source\repos\youtube-dl-1\youtube_dl\extractor\funimation.py", line 101, in _real_extract
    ], webpage, fatal=True)
  File "C:\Users\Nasir\source\repos\youtube-dl-1\youtube_dl\extractor\common.py", line 1142, in _html_search_meta
    html, display_name, fatal=fatal, group='content', **kwargs)
  File "C:\Users\Nasir\source\repos\youtube-dl-1\youtube_dl\extractor\common.py", line 1021, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags, group)
  File "C:\Users\Nasir\source\repos\youtube-dl-1\youtube_dl\extractor\common.py", line 1012, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract al:web:url; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.


Process finished with exit code 1

@Mevious Mevious closed this May 4, 2021
@Mevious
Copy link
Author

Mevious commented May 4, 2021

Closed. Didn't notice this was already fixed. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Funimation fails to parse JSON
1 participant