Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMP] Fix upload_date and timestamp extraction #27970

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

adrianheine
Copy link
Contributor

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Copy link
Collaborator

@remitamine remitamine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BleacherReportCMSIE test is also affected by this change.

youtube_dl/extractor/amp.py Show resolved Hide resolved
@adrianheine
Copy link
Contributor Author

BleacherReportCMSIE test is also affected by this change.

That video seems to not be available anymore anyway.

@remitamine
Copy link
Collaborator

BleacherReportCMSIE test is also affected by this change.

That video seems to not be available anymore anyway.

the extractor does not rely on the webpage.

@adrianheine
Copy link
Contributor Author

the extractor does not rely on the webpage.

You're right, thanks for your diligence.

@remitamine remitamine merged commit d18f441 into ytdl-org:master Jan 26, 2021
ThirumalaiK pushed a commit to ThirumalaiK/youtube-dl that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants