Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idf1_extractor] Add new extractor (fulfilling support request #25671) #25735

Closed
wants to merge 1 commit into from

Conversation

bmensah
Copy link

@bmensah bmensah commented Jun 19, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

In issue #25671 opened on June 15, a youtube-dl user requested that an extractor for videos from the site "idf1.fr" be added, with two example videos attached to the post. This pull request aims to resolve that issue.

@dstftw
Copy link
Collaborator

dstftw commented Jun 19, 2020

Have you even bothered to test it?

@dstftw dstftw closed this Jun 19, 2020
@dstftw dstftw added the invalid label Jun 19, 2020
@bmensah
Copy link
Author

bmensah commented Jun 20, 2020

Hi! my apologies; new to this. I thought that since all my unit tests passed, it was alright to go ahead and submit a pull request. I see now that even though the unit tests returned ok, trying to actually download the video still gives an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants