-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zoomus] Add new extractor #24751
[zoomus] Add new extractor #24751
Conversation
Read coding conventions. |
@dstftw I have adjusted the regexes to ignore non important fields and some other code convention stuff. |
d79a33f
to
2a4bda2
Compare
@sheedy You simply drop the |
Works well for me. Thanks @Romern |
Hello @Romern,
am I doing something incorrectly? I can help to debug or in the extractor itself. |
@o1dnik It seems like your link does not match the pattern, could you post it? If its sensitive, you can censor the id. |
I'm not sure, but it should be publicly available. This is a TheEconomist magazine video recording |
…t throw warning if password field not found
@o1dnik it should now work for arbitrary long ids. |
@Romern I confirm, works like charming! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex is not working. It seems there are unescaped slashes that python doesn't like. The correct one should look like this: https:\/\/(?:.*).?zoom.us\/rec(?:ording)?\/play\/(?P<id>[A-Za-z0-9\-_]+)
PS: Great work @Romern ! With the fixed regex it works!
@kcrkor In python you do not need to escape forward-slashes. On regex101.com you an set the regex-flavor to python and the current one works fine. |
@karbassi Looks good to me. |
@dstftw thoughts on merging? |
5e26784
to
da2069f
Compare
Continued here: #27002 |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This is an extractor for Zoom.us recordings. Example link taken from here: #16597 .
Other related Issues: #23573 , #24643 , #16597
I don't know how to get the tests working, somehow the md5 is None, even though the file is being downloaded when using
--test
manually.