-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Camsoda] Add new extractor #22036
base: master
Are you sure you want to change the base?
[Camsoda] Add new extractor #22036
Conversation
Does not work:
Also read coding conventions. |
Im actually not sure why you are getting the error with that version of python, it works fine with the others ... i dont have that version to test so i would need help figuring that out |
stream_name=video_data['stream_name'], | ||
token=video_data['token']) | ||
|
||
formats = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inline.
|
||
user = user_data.get('user') | ||
if user: | ||
thumb = user.get('thumb') or user.get('profile_picture') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaks on non dict user
.
corrected order of video id and note changed str to compat_str removed query from string and passed as var changed str.format to old style %operator check to make sure user is a dict
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
###Add new extractor camsoda to download live streams from the site