Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DigitallySpeaking] Support uncommon DigitallySpeaking case #21080

Closed
wants to merge 2 commits into from
Closed

[DigitallySpeaking] Support uncommon DigitallySpeaking case #21080

wants to merge 2 commits into from

Conversation

zorbathut
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Some rare GDC Vault videos, hosted by DigitallySpeaking, have no speakerVideo element but store the entire video within slideVideo (https://gdcvault.com/play/1016624, https://gdcvault.com/play/1016625, more). Unfortunately, the DigitallySpeaking extractor considers that a fatal error and refuses to download them.

This change accepts videos without either a speakerVideo or a slideVideo element.

@dstftw
Copy link
Collaborator

dstftw commented May 13, 2019

Add a test.

@zorbathut
Copy link
Author

Moved to #28970 .

@zorbathut zorbathut closed this May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants