[porntrex] Add New Extractor for porntrex.com Provides [PornTrex] and [PornTrexPlayList] #20706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is to set up the environment correctly for updating and merging changes as they arise.
nindogo
changed the title
Added login and password to playlist class. Also added a new playlist for the the test of the playlist class. I do not know how to test the credentials in youtube-dl yet so needed a class that did not need username and password and that had all its videos available for access.
Some clean ups to remove overly specific url that appears to change daily.
It looks better when the extractor informs the user that it is looking at the file for data.
nindogo
changed the title
Reorganised the script adding a PornTrexBaseIE class that will be used for shared methods. Currently hosting only two methods: 1. _login 2. _real_initialize
nindogo
changed the title
nindogo
changed the title
The video that we used to test the previous version of porntrex.py is no longer on the website. This led to failures in the tests. Here we have a corrected version with working URL.
dstftw
requested changes
May 10, 2019
Four changes made as requested.
Hopefully also make things pythonic.
9 tasks
dstftw
requested changes
Jun 22, 2019
|
@ofdogsan nobody actually owes you anything here. I don't feel like I should bother re-review over and over again if one does not even bother to read coding conventions.
Go for it. And spend all your free time maintaining it if you want. We'll see for how long you can last. |
Changes done to close pending fixes raised by youtube_dl maintainer.
Changed regex to reduce the chance of getting string if it is an empty string.
|
Hi @botzill, thanks for your efforts. I like how you imported the json object and may change this to be similar to that. |
|
Thx @nindogo , would be great if you could include all the other fields as I need them as well. Thx a lot! |
|
Hi. I'm new using youtube-dl extractors and I want to run this on google Colab (already using youtube-dl itself on Colab) but I don't have any idea how to start using this extractor on anywhere! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
New extractor for porntrex.com provides [PornTrex] and [PornTrexPlayList]