Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mp4upload] new extractor (updated) #16958

Closed
wants to merge 7 commits into from
Closed

Conversation

bato3
Copy link
Contributor

@bato3 bato3 commented Jul 12, 2018

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

youtube_dl/extractor/mp4upload.py Outdated Show resolved Hide resolved
youtube_dl/extractor/mp4upload.py Outdated Show resolved Hide resolved
youtube_dl/extractor/mp4upload.py Outdated Show resolved Hide resolved
youtube_dl/extractor/mp4upload.py Outdated Show resolved Hide resolved
youtube_dl/extractor/mp4upload.py Outdated Show resolved Hide resolved
youtube_dl/extractor/mp4upload.py Outdated Show resolved Hide resolved
youtube_dl/extractor/mp4upload.py Outdated Show resolved Hide resolved
youtube_dl/extractor/mp4upload.py Outdated Show resolved Hide resolved
@bato3
Copy link
Contributor Author

bato3 commented Jul 13, 2018

  • 'url': poor_info_dict.get('formats')[0].get('url'),

I hope it was about: .get('formats', [{}])

  • "Breaks on unexpected data." time.mktime(time.strptime

I can not deal with it other than try/except

youtube_dl/extractor/mp4upload.py Outdated Show resolved Hide resolved
youtube_dl/extractor/mp4upload.py Outdated Show resolved Hide resolved
youtube_dl/extractor/mp4upload.py Outdated Show resolved Hide resolved
youtube_dl/extractor/mp4upload.py Outdated Show resolved Hide resolved
youtube_dl/extractor/mp4upload.py Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Feb 2, 2019

Bump (if such exists on GH)
#19103

This one is definitely better

@loso20p
Copy link

loso20p commented Jul 29, 2019

does this still grab mp4upload links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defunct PR source branch is not accessible pending-fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants