Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BlenderCloud] Add new extractor (fixes issue #13282) #13484

Closed
wants to merge 32 commits into from

Conversation

parmjitv
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • [ x] I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • [x ] New extractor
  • New feature

Description of your pull request and other information

Added a new extractor for the Blender Cloud platform [https://cloud.blender.org/] - issue #13282.

This site provides a variety of training videos for the Blender 3D creation suite.

Please note this extractor will ignore any subscriber-only videos - these require a Blender ID token and enrolment in the Blender Cloud Membership program, which AFAIK is a paid subscription.

Cheers and thank you!

Parmjit V.

@parmjitv
Copy link
Contributor Author

parmjitv commented Jul 7, 2017

Does this PR require any corrections? Please let me know and I will be happy to update as needed. Thanks!

@parmjitv
Copy link
Contributor Author

parmjitv commented Jul 8, 2017

Does this PR require any corrections? Thank you!

@parmjitv
Copy link
Contributor Author

@dstftw - Can you please review at your convenience? I would like to have this PR resolved before I move on to the next issue, if at all possible. Thanks!

@ytdl-org ytdl-org locked and limited conversation to collaborators Jul 10, 2017
@dstftw
Copy link
Collaborator

dstftw commented Jul 14, 2017

Lots of code duplication.

@parmjitv
Copy link
Contributor Author

parmjitv commented Sep 3, 2017

@dstftw - I have refactored the extractor to address the code duplication, please review at your convenience. Cheers!

@parmjitv
Copy link
Contributor Author

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants