Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Full30] Add new extractor #12988

Closed
wants to merge 5 commits into from
Closed

Conversation

iamevn
Copy link

@iamevn iamevn commented May 5, 2017

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Added extractor for videos from full30.com. Supports video pages like https://www.full30.com/video/037167e3d36fc906bab655d6646347a8.

@dstftw
Copy link
Collaborator

dstftw commented May 5, 2017

Bother to read

adding new extractor tutorial and youtube-dl coding conventions sections

and fix all issues.

iamevn added 2 commits May 6, 2017 02:17
…back to video_id as title (current behavior with generic exractor), make filesize int_or_none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defunct PR source branch is not accessible pending-fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants