[gedi] Add new extractor #26946
Closed
[gedi] Add new extractor #26946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remitamine
reviewed
Feb 19, 2021
remitamine
requested changes
Feb 19, 2021
- improved and simplified formats extraction using _extract_akamai_formats - test md5 fix - improved thumbnail extraction
- improved title extraction with fallback value - added timestamp (with tests) - added fallback values for description and thumbnail - improved regex to extract video player data - removed custom IE_NAME
- removed http direct url creation (no longer necessary after extract_akamai_formats teke care of it) - removed audio format clean-up
remitamine
requested changes
Feb 20, 2021
remitamine
requested changes
Feb 20, 2021
- removed 'image_full_play' from thumbnail url extraction and adjusted test value - removed 'modified_time' as a value to timestamp generation - put 'only_matching' to some no longer necessary tests - added 'ipad' tag to hls formats selection
remitamine
reviewed
Feb 21, 2021
- removed md5 leftover in test - added comment in test for .strip() necessity - changed default='' to fatal=False in _og_search_property for timestamp genaration
|
@remitamine remember the looong conversation ;-) we had last month about the vvvvid extractor "season" title? ;-) In the end I think the solution was to set the When you have time can you give a look at it here #27618 so we can close the vvvvid extractor for good. |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
A new extractor for the various Gedi group italian newspaper websites like repubblica.it and lastampa.it among the biggest.
It closes #7347 (and #20835)