Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube-dl no longer downloads from xHamster #26282

Closed
5 tasks done
Hermitic opened this issue Aug 8, 2020 · 5 comments · Fixed by #26254
Closed
5 tasks done

Youtube-dl no longer downloads from xHamster #26282

Hermitic opened this issue Aug 8, 2020 · 5 comments · Fixed by #26254

Comments

@Hermitic
Copy link

Hermitic commented Aug 8, 2020

Checklist

  • I'm reporting a broken site support
  • I've verified that I'm running youtube-dl version 2020.07.28
  • I've checked that all provided URLs are alive and playable in a browser
  • I've checked that all URLs and arguments with special characters are properly quoted or escaped
  • I've searched the bugtracker for similar issues including closed ones

Verbose log

PASTE VERBOSE LOG HERE

C:\Users\S\Downloads\Youtube-dl>youtube-dl -v https://xhamster.com/videos/henry-
and-june-1990-english-xhOK2Wv
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://xhamster.com/videos/henry-and-june-19
90-english-xhOK2Wv']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2020.07.28
[debug] Python version 3.4.4 (CPython) - Windows-8.1-6.3.9600
[debug] exe versions: ffmpeg git-2020-07-29-cbb6ba2, ffprobe git-2020-07-29-cbb6
ba2
[debug] Proxy map: {}
[XHamster] 1990: Downloading webpage
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug
 . Make sure you are using the latest version; type  youtube-dl -U  to update. B
e sure to call youtube-dl with the --verbose flag and include its complete outpu
t.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whux
ta\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whux
ta\build\youtube_dl\extractor\common.py", line 530, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whux
ta\build\youtube_dl\extractor\xhamster.py", line 242, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whux
ta\build\youtube_dl\extractor\common.py", line 1350, in _sort_formats
youtube_dl.utils.ExtractorError: No video formats found; please report this issu
e on https://yt-dl.org/bug . Make sure you are using the latest version; type  y
outube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and
include its complete output.

Description

WRITE DESCRIPTION HERE

I have used youtube-dl on my Windows 8.1 OS without a problem for several months. Approximately a week or two weeks ago it ceased working with xHamster. It still downloads flawlessly from other sites.

@nicolaasjan
Copy link

nicolaasjan commented Aug 9, 2020

Duplicate of #26157 I think.

I can confirm that changing one line in the source code and compile it again, fixes it.
Easy on Linux, but I don't know how to do that in Windows.
You will have to ask here or investigate yourself, I'm afraid...
Or wait till a fix in a new version.

@hitam4450
Copy link

Any progress to fix this issue ??

@Hermitic
Copy link
Author

Any progress to fix this issue ??

There seems to be a solution for the Linux variant of youtube-dl, but this being the Windows variant we may have to wait until programmers release an update.

@TheRealDude2
Copy link
Contributor

TheRealDude2 commented Aug 12, 2020

This is true, at least if you want to use the compiled EXE file.

But if you have python installed as a full version, I think it should work just like the Linux version. But I could be wrong on this point.

Update:
I have just installed Python on a Windows PC. After that you can actually run youtube_dl normally (see DEVELOPER INSTRUCTIONS in documentation), with the adapted changes in the extractors.

@nicolaasjan
Copy link

nicolaasjan commented Aug 12, 2020

This is true, at least if you want to use the compiled EXE file.

But if you have python installed as a full version, I think it should work just like the Linux version. But I could be wrong on this point.

Update:
I have just installed Python on a Windows PC. After that you can actually run youtube_dl normally (see DEVELOPER INSTRUCTIONS in documentation), with the adapted changes in the extractors.

Actually building the Windows executable is not very difficult.
Found instructions here.

  1. If you don't already have it, install Python.
  2. In an elevated command prompt run:
    python.exe -m pip install pyinstaller
  3. Download the youtube-dl source code: https://github.com/ytdl-org/youtube-dl/archive/master.zip
  4. Extract to the folder youtube-dl-master.
  5. Change line 132 in youtube-dl-master\youtube_dl\extractor\xhamster.py to:
    r'window.initials\s*=\s*({.+?})\s*;\s*', webpage, 'initials',
  6. Open a command prompt in the folder youtube-dl-master and run:
    pyinstaller.exe youtube_dl\__main__.py --onefile --name youtube-dl
  7. youtube-dl.exe can then be found in the dist subdirectory.

I replaced the official .exe file with the newly built one and downloading from xHamster worked again!

[EDIT]
dstftw just committed changes, so it might soon be fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants