Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abc.go.com now abc.com: Video extraction no longer working #22823

Closed
5 tasks done
tmthywynn8 opened this issue Oct 23, 2019 · 2 comments
Closed
5 tasks done

abc.go.com now abc.com: Video extraction no longer working #22823

tmthywynn8 opened this issue Oct 23, 2019 · 2 comments

Comments

@tmthywynn8
Copy link

tmthywynn8 commented Oct 23, 2019

Checklist

  • I'm reporting a broken site support
  • I've verified that I'm running youtube-dl version 2019.10.22
  • I've checked that all provided URLs are alive and playable in a browser
  • I've checked that all URLs and arguments with special characters are properly quoted or escaped
  • I've searched the bugtracker for similar issues including closed ones

Verbose log

$youtube-dl -v https://abc.com/shows/the-rookie/episode-guide/season-02/03-the-bet
[debug] System config: []
[debug] User config: ['--abort-on-unavailable-fragment', '--ap-mso', 'Comcast_SSO', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE', '--no-geo-bypass', '--fixup', 'never', '--fragment-retries', '1', '--no-check-certificate', '--hls-prefer-native', '-f', 'bestaudio', '--prefer-ffmpeg']
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://abc.com/shows/the-rookie/episode-guide/season-02/03-the-bet']
[debug] Encodings: locale cp1252, fs mbcs, out cp1252, pref cp1252
[debug] youtube-dl version 2019.10.22
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.16299
[debug] exe versions: ffmpeg 4.1, ffprobe 3.3.3, rtmpdump 2.4
[debug] Proxy map: {}
[generic] 03-the-bet: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 03-the-bet: Downloading webpage
[generic] 03-the-bet: Extracting information
ERROR: Unsupported URL: https://abc.com/shows/the-rookie/episode-guide/season-02/03-the-bet
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpifszpy0p\build\youtube_dl\YoutubeDL.py", line 796, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpifszpy0p\build\youtube_dl\extractor\common.py", line 530, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpifszpy0p\build\youtube_dl\extractor\generic.py", line 3353, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://abc.com/shows/the-rookie/episode-guide/season-02/03-the-bet

Description

Between October 21 and October 23, ABC stopped using the go domain for their videos, e.g., instead of:
https://abc.go.com/shows/the-rookie/episode-guide/season-02/03-the-bet
the link is now:
https://abc.com/shows/the-rookie/episode-guide/season-02/03-the-bet

Unfortunately, though there is still traffic coming from go.com as well as uplynk.com, youtube-dl is unable to retrieve ABC content—presumably because there's no regexp to account for the new domain change in the go extractor.

If possible, can the go extractor be modified to account for the domain change from abc.go.com to just abc.com?

Update: Unfortunately, the fix is not as simple as just changing the URL regexp, as even with the modifications locally on my end, it can't find the video ID. I'll have to take a closer look at the extractor's source and see what code changes were made on ABC's end that broke the functionality.

@dwalkerdon
Copy link

dwalkerdon commented Oct 26, 2019

I hope that this gets fixed very quickly!

@kucksdorfs
Copy link

Well since the comments have been here for a while and I don't see any pull requests referencing this issue. I'll create the PR for it. Not sure what the youtube-dl teams schedule is like, but when I submitted my last PR it was in the next release or two (no more than a few days from PR accepted to in the release).

@ytdl-org ytdl-org deleted a comment from tmthywynn8 Oct 28, 2019
@ytdl-org ytdl-org deleted a comment from auouymous Oct 28, 2019
@ytdl-org ytdl-org deleted a comment from channelmars Oct 28, 2019
@ytdl-org ytdl-org locked and limited conversation to collaborators Oct 28, 2019
@dstftw dstftw closed this as completed in dd90a21 Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants