Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crunchyroll] Title extractor broken #21291

Closed
5 tasks done
WhiteRabbit56 opened this issue Jun 3, 2019 · 5 comments
Closed
5 tasks done

[Crunchyroll] Title extractor broken #21291

WhiteRabbit56 opened this issue Jun 3, 2019 · 5 comments
Labels

Comments

@WhiteRabbit56
Copy link

WhiteRabbit56 commented Jun 3, 2019

Checklist

  • I'm reporting a broken site support
  • I've verified that I'm running youtube-dl version 2019.05.20
  • I've checked that all provided URLs are alive and playable in a browser
  • I've checked that all URLs and arguments with special characters are properly quoted or escaped
  • I've searched the bugtracker for similar issues including closed ones

Verbose log

youtube-dl.exe --verbose https://www.crunchyroll.com/fruits-basket
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://www.crunchyroll.com/fruits-basket']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2019.05.20
[debug] Python version 3.7.2 (CPython) - Windows-10-10.0.17763-SP0
[debug] exe versions: ffmpeg N-93542-gecdaa4b4fa, phantomjs 2.1.1
[debug] Proxy map: {}
[crunchyroll:playlist] fruits-basket: Downloading webpage
ERROR: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "c:\program files\python\lib\site-packages\youtube_dl\YoutubeDL.py", line 796, in extract_info
    ie_result = ie.extract(url)
  File "c:\program files\python\lib\site-packages\youtube_dl\extractor\common.py", line 529, in extract
    ie_result = self._real_extract(url)
  File "c:\program files\python\lib\site-packages\youtube_dl\extractor\crunchyroll.py", line 666, in _real_extract
    webpage, 'title')
  File "c:\program files\python\lib\site-packages\youtube_dl\extractor\common.py", line 1013, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags, group)
  File "c:\program files\python\lib\site-packages\youtube_dl\extractor\common.py", line 1004, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

Crunchyroll has updated their website, breaking the name regex.
Changing the regex on line 665 of extractor/crunchyroll.py resolves the issue.

r'(?s)<h1[^>]*>\s*<span itemprop="name">(.*?)</span>'

to

r'(?s)<meta content="(.*?)" itemprop="name">'

@Tazeki
Copy link

Tazeki commented Jun 5, 2019

Can confirm I'm having the same issue with all playlists. Thank you @WhiteRabbit56 for the quick fix!

@ytdl-org ytdl-org deleted a comment from Lame11a Jun 7, 2019
@SwimmingLink
Copy link

Sorry for my ignorance, but is there an easy way for me to make this fix in Windows before the official fix is released? I only have my .exe. :\

dunn referenced this issue in dunn/youtube-dl Jun 18, 2019
@alexpizarroj
Copy link

@dstftw Is the PR from dunn good enough to merge? Can confirm I'm having the same issue on the windows version.

@dstftw dstftw closed this as completed in 4681441 Jun 21, 2019
@SwimmingLink
Copy link

This still isn't working for me. Was the fix not included in the latest update? (Windows)

@dstftw
Copy link
Collaborator

dstftw commented Jun 21, 2019

Not included.

@ytdl-org ytdl-org locked and limited conversation to collaborators Jun 21, 2019
@dstftw dstftw added the fixed label Jun 21, 2019
meunierd referenced this issue in meunierd/youtube-dl Dec 27, 2019
meunierd referenced this issue in meunierd/youtube-dl Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants