Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[twitch:vod] youtube-dl doesn't show "source" in the format list. It's important for 720/30 recorded videos. #19193

Closed
5 of 9 tasks
juanfra684 opened this issue Feb 11, 2019 · 1 comment

Comments

@juanfra684
Copy link
Contributor

juanfra684 commented Feb 11, 2019

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.02.08. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2019.02.08

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

Description of your issue, suggested solution and other information

I've included two outputs below. The first url is a video recorded in 720p at 30 frames. The second url is 900p at 60 frames. Both don't include the "source" label in the format list. In the second url, you know that the source is 900p because twitch doesn't re-encode to that resolution. The problem for me is the first url because I can't know what is the source, 720p-0 or 720p-1. I've seen other urls with both formats within the range of 2200-2300k/s (and avc1.4D401F), so even the bitrate is not really helping to know what is the source.

For both videos, the twitch web shows the source in the list of format. So, my request is to include a "source" label in the format list, like you're doing for live streams.

$ youtube-dl -v -F 'https://www.twitch.tv/videos/378760727'
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-F', 'https://www.twitch.tv/videos/378760727']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.02.08
[debug] Python version 3.7.2 (CPython) - Linux-4.19.20
[debug] exe versions: ffmpeg 4.1.1, ffprobe 4.1.1, rtmpdump 2.4
[debug] Proxy map: {}
[twitch:vod] 378760727: Downloading vod info JSON
[twitch:vod] 378760727: Downloading vod access token
[twitch:vod] 378760727: Downloading m3u8 information
[info] Available formats for v378760727:
format code  extension  resolution note
Audio_Only   mp4        audio only  203k , mp4a.40.2
160p         mp4        284x160     284k , avc1.4D400C, mp4a.40.2
360p         mp4        640x360     700k , avc1.4D401E, mp4a.40.2
480p         mp4        852x480    1418k , avc1.4D401E, mp4a.40.2
720p-0       mp4        1280x720   2213k , avc1.4D401F, mp4a.40.2
720p-1       mp4        1280x720   2778k , avc1.64001F, mp4a.40.2 (best)
$ youtube-dl -v -F 'https://www.twitch.tv/videos/378524093'
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-F', 'https://www.twitch.tv/videos/378524093']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.02.08
[debug] Python version 3.7.2 (CPython) - Linux-4.19.20
[debug] exe versions: ffmpeg 4.1.1, ffprobe 4.1.1, rtmpdump 2.4
[debug] Proxy map: {}
[twitch:vod] 378524093: Downloading vod info JSON
[twitch:vod] 378524093: Downloading vod access token
[twitch:vod] 378524093: Downloading m3u8 information
[info] Available formats for v378524093:
format code  extension  resolution note
Audio_Only   mp4        audio only  215k , mp4a.40.2
160p         mp4        284x160     284k , avc1.4D400C, mp4a.40.2
360p         mp4        640x360     693k , avc1.4D401E, mp4a.40.2
480p         mp4        852x480    1406k , avc1.4D401E, mp4a.40.2
720p         mp4        1280x720   2204k , avc1.4D401F, mp4a.40.2
720p60       mp4        1280x720   3099k , avc1.4D401F, mp4a.40.2
900p60       mp4        1600x900   7426k , avc1.64002A, mp4a.40.2 (best)
@dstftw dstftw closed this as completed in 985637c Feb 11, 2019
@juanfra684
Copy link
Contributor Author

@dstftw Many thanks for the quick fix. Wouldn't it better to use the format id for the "source" label, instead of the note field?. Mostly, for consistency with the live streams. This is the output from a live stream:

$ youtube-dl -F 'https://www.twitch.tv/ryux'            
[twitch:stream] ryux: Downloading stream JSON
[twitch:stream] ryux: Downloading channel access token
[twitch:stream] ryux: Downloading m3u8 information
[info] Available formats for 32678871456:
format code      extension  resolution note
audio_only       mp4        audio only   13k , mp4a.40.2
160p             mp4        284x160     230k , avc1.4D401F, mp4a.40.2
360p             mp4        640x360     630k , avc1.4D401F, mp4a.40.2
480p             mp4        852x480    1274k , avc1.4D401F, mp4a.40.2
720p             mp4        1280x720   2219k , avc1.4D401F, mp4a.40.2
720p60           mp4        1280x720   3269k , avc1.4D401F, mp4a.40.2
720p60__source_  mp4        1280x720   6555k , avc1.4D4020, mp4a.40.2 (best)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant