Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic extractor cognito idp - import library #15274

Open
1 of 5 tasks
wernerkarlheisenberg opened this issue Jan 16, 2018 · 2 comments
Open
1 of 5 tasks

generic extractor cognito idp - import library #15274

wernerkarlheisenberg opened this issue Jan 16, 2018 · 2 comments

Comments

@wernerkarlheisenberg
Copy link

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

I updating the extractor for VIER. Authentication part is no longer working as the website moved to AWS Cognito IDP for authentication. I want create a general extractor for Cognito IDP (I'm assuming that other sites will also start using the platform for authentication in the future.). There is a very neat python library (warrant) that already has support for Cognito IDP, so rather than reinventing the wheel, I would like to import that package (which will generate a new dependency.). Would that be allowed?

@yan12125
Copy link
Collaborator

For this case, +1 for using warrant. It depends on AWS SDK boto3, and I don't think anyone wants to reimplement that.

An issue is that youtube-dl for Windows is built against Python 3.4 for supporting Windows XP (#10014), and looks like it doesn't explicitly state support for 3.4:

https://github.com/capless/warrant/blob/ff2e4793d8479e770f2461ef7cbc0c15ee784395/setup.py#L20

@wernerkarlheisenberg
Copy link
Author

I did a quick test on my MacBook using python 3.4.7 and it worked without any problem. So my conclusion is that for Cognitto IDP, python 3.4 is sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants