Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pornhub categories and tags not parsing #13720

Closed
4 of 8 tasks
burnersauce opened this issue Jul 24, 2017 · 0 comments
Closed
4 of 8 tasks

pornhub categories and tags not parsing #13720

burnersauce opened this issue Jul 24, 2017 · 0 comments

Comments

@burnersauce
Copy link

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like that [x])
  • Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.07.23. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2017.07.23

Before submitting an issue make sure you have:

  • At least skimmed through README and most notably FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue


If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:

Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):

 $ youtube-dl -v --skip-download --write-info-json https://www.pornhub.com/view_video.php\?viewkey\=ph589177565b9e6
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '--skip-download', '--write-info-json', 'https://www.pornhub.com/view_video.php?viewkey=ph589177565b9e6']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.07.23
[debug] Python version 3.6.1 - Darwin-13.4.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.2.2, ffprobe 3.2.2, rtmpdump 2.4
[debug] Proxy map: {}
[PornHub] ph589177565b9e6: Downloading webpage
[PornHub] ph589177565b9e6: Downloading webpage
[info] Writing video description metadata as JSON to: Behind the scenes on set!-ph589177565b9e6.info.json
<end of log>

Description of your issue, suggested solution and other information

The current parsing does not correctly capture categories and tags (used when extracting info as json). The current implementation seeks to read the categories and tags out of the page_params field. The page params, however, do not currently contain this info. Instead, they only contain the keys: ['height', 'width', 'zoneId', 'special', 'dynamicId', 'adTypeParent', 'adTypeChild', 'frameId']. As such, all pages have the categories value as [] and likewise for the tags value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant