-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signature extraction failed: Traceback (most recent call last) #11663
Comments
also having this issue :( |
I'm having this issue too. |
Seem like youtube updated the layout, caused by something like this |
Can anyone run |
OK I got this bug, too |
@yan12125 Still need to upload *.dump files or not? as i can't attach zip file here |
@yan12125 Here's the *.dump files: https://www.sendspace.com/filegroup/JhlFwck9rTaglBTPq6nYRS88mETW2kvb |
Would just like to make it known that I am having this same issue. |
I've got the same issue. |
"I'm having the same issue" and "+1" comments are just creating noise at this point. It's a known issue, there will be a fix soon. Please consider this before posting here. |
Here's an ad-hoc fix: diff --git a/youtube_dl/extractor/youtube.py b/youtube_dl/extractor/youtube.py
index 335568a10..aaa8d2b0c 100644
--- a/youtube_dl/extractor/youtube.py
+++ b/youtube_dl/extractor/youtube.py
@@ -1267,6 +1267,7 @@ class YoutubeIE(YoutubeBaseInfoExtractor):
# Try looking directly into the video webpage
ytplayer_config = self._get_ytplayer_config(video_id, video_webpage)
if ytplayer_config:
+ player_url = ytplayer_config.get('url')
args = ytplayer_config['args']
if args.get('url_encoded_fmt_stream_map'):
# Convert to the same format returned by compat_parse_qs
@@ -1552,7 +1553,8 @@ class YoutubeIE(YoutubeBaseInfoExtractor):
jsplayer_url_json = self._search_regex(
ASSETS_RE, embed_webpage, 'JS player URL')
- player_url = json.loads(jsplayer_url_json)
+ if player_url is None:
+ player_url = json.loads(jsplayer_url_json)
if player_url is None:
player_url_json = self._search_regex(
r'ytplayer\.config.*?"url"\s*:\s*("[^"]+")', Please upload dump files if this does not work for you. |
@yan12125 works for me for a simple test. Thanks. |
@yan12125 fails with trace for removed videos. E.g.:
|
@Kagami Hurry brings bad codes :-) |
Yet another hack: Index: youtube_dl/jsinterp.py
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- youtube_dl/jsinterp.py (date 1483978139000)
+++ youtube_dl/jsinterp.py (revision )
@@ -213,7 +213,7 @@
def extract_object(self, objname):
obj = {}
obj_m = re.search(
- (r'(?:var\s+)?%s\s*=\s*\{' % re.escape(objname)) +
+ (r'(?<!this\.)%s\s*=\s*\{' % re.escape(objname)) +
r'\s*(?P<fields>([a-zA-Z$0-9]+\s*:\s*function\(.*?\)\s*\{.*?\}(?:,\s*)?)*)' +
r'\}\s*;',
self.code)
|
@dstftw Mind applying your patch to master? Although that's dirty, it's better than going back to the old Flash way. |
Done and released. |
Thanks! |
@crazedpsyc The fix is included in 2017.01.10; see https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl |
how do i open the script panel thing, sorry im new to this. how do i fix this? |
@KitoHD How did you install youtube-dl? |
This issue is already fixed. Read this FAQ entry if you have troubles updating. |
The title says about this issue.
Before creating this issue, i already search and read some issues related to mine, such as: #7413 , #10019 , #3255 , #4603 and similar issue in other places by Google search. Most of them said it's caused by out of date version of youtube-dl.
What i've done is like below:
pip install --upgrade youtube-dl
pip
, replace using latest build exe for windowsSame result. None of them are worked.
The text was updated successfully, but these errors were encountered: