Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: downstream instability #291

Closed
neutrinoceros opened this issue Oct 11, 2022 · 3 comments
Closed

TST: downstream instability #291

neutrinoceros opened this issue Oct 11, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@neutrinoceros
Copy link
Member

Description

looks like merging #200 caused a regression in yt
https://github.com/yt-project/yt/actions/runs/3223984952/jobs/5274634351

I'll take care of this today if I can

@neutrinoceros neutrinoceros self-assigned this Oct 11, 2022
@neutrinoceros neutrinoceros added the bug Something isn't working label Oct 11, 2022
@neutrinoceros
Copy link
Member Author

So the problem is that, in yt, some code has been written that relies on the old behaviour of, say np.dot, dropping units on unyt arrays.

The code can (and likely should) be adapted on yt's side, but it seems to me that it'd be best to consider that a fully NEP 18 compliant version of unyt (as is being developed starting with #200, see #289), should be numbered 3.0.0 instead of 2.10.0.
@ngoldbaum WDYT ?

@ngoldbaum
Copy link
Member

Yes, definitely, the next release is unyt 3.0

@neutrinoceros
Copy link
Member Author

Cool. I don't think there's any actionable left for now so I'll close this but just to make sure everybody is on the same page I'll ping @jzuhone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants