-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/rozhlas] Add MujRozhlas
extractor
#7129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashonly
requested changes
May 27, 2023
bashonly
requested changes
May 31, 2023
@stanoarn Test my changes and let me know what you think |
Sorry, I was busy with real life stuff, thank you for doing all the hard work. I've added comments explaining which kind of extraction is being tested, and replaced the test for serials, since the one we had been testing has since been removed. Everything else looks alright. |
bashonly
approved these changes
Jun 6, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: stanoarn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This PR refactors some code from the old RozhlasVltavaIE. This is mainly done so that some of its code can be reused for a new MujRozhlasIE. This new extractor allows for the extraction of data from mujrozhlas.cz. While the data is mostly extractable with the old extractor, the new one is able fetch some addition information (e.g. upload dates) and also works on a different website. The underlying API is the same, but I haven't been able to figure out a way to unify the extraction process.
Fixes #
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at d6c32c4
Summary
🎧🇨🇿🛠️
Add support for mujrozhlas.cz, a Czech radio website, and improve the existing extractor for rozhlas.cz. Refactor
rozhlas.py
to share common code and logic between the two extractors. Enhance the error handling and audio format extraction for both sites.Walkthrough
MujRozhlasIE
extractor to handle mujrozhlas.cz URLs (link, link)_extract_video
method ofRozhlasVltavaIE
to extract audio formats (link)rozhlas.py
(link)