Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

both: support m4a and aac #1548

Open
4 tasks
yss14 opened this issue May 8, 2020 · 0 comments
Open
4 tasks

both: support m4a and aac #1548

yss14 opened this issue May 8, 2020 · 0 comments
Assignees
@Freshchris01
Labels
backend enhancement Enhancement to a already existing feature frontend refactoring v1.1 Planned for version v1.1

Comments

@yss14
Copy link
Owner

yss14 commented May 8, 2020

Backend

  • simplify meta data extraction
    • move extraction logic to SongMetaDataService using music-metadata
    • remove ID3MetaData.ts and MP3SongDuration.ts
  • replace id3-parser with music-metadata
  • add test cases for m4a and aac

Frontend

  • allow mime types of m4a and aac
@yss14 yss14 added backend enhancement Enhancement to a already existing feature frontend refactoring v1.0 Issue to be done for v1.0 release labels May 8, 2020
@yss14 yss14 added v1.1 Planned for version v1.1 and removed v1.0 Issue to be done for v1.0 release labels May 16, 2020
@yss14 yss14 mentioned this issue Mar 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Freshchris01 Freshchris01

Labels
backend enhancement Enhancement to a already existing feature frontend refactoring v1.1 Planned for version v1.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Freshchris01 @yss14