Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI support for "every nth" interval #54

Closed
lovelldies opened this issue Aug 26, 2022 · 9 comments
Closed

UI support for "every nth" interval #54

lovelldies opened this issue Aug 26, 2022 · 9 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@lovelldies
Copy link

It would be nice if the form supported options like */5 * * * * (every 5th minute).

@madsthom madsthom added hacktoberfest enhancement New feature or request labels Oct 1, 2022
@madsthom
Copy link
Collaborator

madsthom commented Oct 1, 2022

I will try and work on this. But if you want a go at it yourself, go ahead and submit a PR!

@madsthom madsthom assigned madsthom and unassigned madsthom Oct 1, 2022
@AhsanAyaz
Copy link
Contributor

@madsthom if I'm correct, this means providing the following:

  • Every nth minute
  • Every nth hours at X minutes past
  • Every nth day at X hours and Y minutes. And so on.
    Is that accurate? Because that means an entire feature rather than minor enhancement.
    I'm happy to introduce a PR for just every nth minute!

@lovelldies
Copy link
Author

I'm happy to introduce a PR for just every nth minute!

This would be sufficient, at least for my use case.

@madsthom
Copy link
Collaborator

@AhsanAyaz you can go ahead with this. 👍🏼 I am currently investigating a problem with the angular 14 upgrade.

@AhsanAyaz
Copy link
Contributor

@madsthom , already submitted a PR for this 🙂
#62

@madsthom
Copy link
Collaborator

Sorry, I totally missed that. 😁 - I will review tonight. 👍🏼

@lovelldies
Copy link
Author

@AhsanAyaz / @madsthom thanks for looking into this!

@madsthom
Copy link
Collaborator

@lovelldies: Please open this again if it does not work as intended.

@lovelldies
Copy link
Author

lovelldies commented Nov 11, 2022

Apologies for the late response. I was on vacation.

Also thanks for working on this. I noticed some unexpected behavior.

Selecting Minute and 5th generates an extra ? at the end. If I'm not mistaken, that seems to be an invalid cron format.

image

Also if I paste */5 * * * * into the textbox, it does not reflect in the selection form.

image

I shall re-open the request after I've heard your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants