Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking Issue] Improve the test coverage #8

Closed
2 of 8 tasks
utam0k opened this issue May 17, 2021 · 13 comments
Closed
2 of 8 tasks

[Tracking Issue] Improve the test coverage #8

utam0k opened this issue May 17, 2021 · 13 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@utam0k
Copy link
Member

utam0k commented May 17, 2021

The current youki has far too few unit tests.
We are planning to increase the test coverage for the following files.
Perhaps this is a very good opportunity to understand the code and how it works. If you are interested, please comment on the issue and declare the files you want to test.

@utam0k utam0k added the good first issue Good for newcomers label May 17, 2021
@ghost
Copy link

ghost commented May 21, 2021

Hi, @utam0k I'd be happy to take capability and tty

@utam0k
Copy link
Member Author

utam0k commented May 21, 2021

@constreference
Thanks for your interest! Sorry, the capability.rs was already assigned to @sensaiankit through a DM exchange. I forgot to update it.
tty.rs is definitely something you should do, but it is the least maintained and may need refactoring. It may be a bit of a challenge, but I'd love to see it done.
Can I assign tty.rs to you?

@ghost
Copy link

ghost commented May 21, 2021

Sure !, I'll give it a shot !

@utam0k utam0k assigned ghost May 21, 2021
@utam0k
Copy link
Member Author

utam0k commented May 21, 2021

I assigned it to you. Looking forward to your PR!

@tsturzl
Copy link
Collaborator

tsturzl commented May 25, 2021

I can take the device cgroup controller testing. I'll just implement the same tests I had done on the other controllers.

@utam0k
Copy link
Member Author

utam0k commented May 26, 2021

@tsturzl Ok! I assigned you.

@bobsongplus
Copy link
Contributor

@utam0k I would like to take src/create.rs or src/namespaces tests

@utam0k
Copy link
Member Author

utam0k commented Jun 10, 2021

@TinySong Thanks for your interest!
I'd love to have you do the create.rs, but it might be a bit challenging. If you have the time and seem to be quite interested, I'd like to ask you to do create.rs. This will be the core youki file.

@bobsongplus
Copy link
Contributor

@utam0k yeah, I love to take that. If i encounter difficulties, I will ask you again,thanks

@utam0k
Copy link
Member Author

utam0k commented Jun 11, 2021

@TinySong Sure. I assigned you to create.rs.

@ghost
Copy link

ghost commented Jun 20, 2021

@utam0k I would like to take rootfs if it's available

@utam0k
Copy link
Member Author

utam0k commented Jun 20, 2021

@constreference Of course. I'm looking forward to working with you.

@utam0k
Copy link
Member Author

utam0k commented Jul 20, 2021

Youki's codes have changed a lot, so I'll close it once.

@utam0k utam0k closed this as completed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants