Skip to content
This repository has been archived by the owner on Nov 19, 2019. It is now read-only.

Angularjs directive for timeline-plus #105

Open
Shavingsoap opened this issue Jan 24, 2019 · 1 comment
Open

Angularjs directive for timeline-plus #105

Shavingsoap opened this issue Jan 24, 2019 · 1 comment
Labels
question Further information is requested

Comments

@Shavingsoap
Copy link

Shavingsoap commented Jan 24, 2019

I'm using an AngularJs directive (angular-vis.js) for enabling to use timeline in an AngularJS situation.
It seems this directive is defective when using timeline-plus. I tried messing around with it, but I don't know exactly how things are being done or how I need to adapt this.

To my research so far I came up with these conclusions:

  • the variable name "timeline' interferes with the object timeline (simple rename will solve this)
  • timeline-plus is using a constant timeline object compared to vis which wasn't a constant object
  • the call to "watch" and "watchcollection" functions (on data and options) is for unknown reason twisted

Hope there's someone out there who can give me a hand to fix this.

@yotamberk
Copy link
Owner

Hi @Shavingsoap ,
I agree the timeline.timeline call is confusing. I hope to change this in the next major version.
timeline-plus uses a const timeline object. Why would it not be?

I don;t quite understand your third point. Please elaborate.

@yotamberk yotamberk added the question Further information is requested label Jan 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants