-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle hashes by default, in addition to normal paths #31
Comments
+1 for query strings, was just thinking about that |
Imo this shouldn't ever impact the routing - if query strings need to be resolved this could be done in a separate function. Perhaps we should provide that - I reckon the node edit: for |
landed in |
Right now there's trouble in hash land. When resolving routes it's either normal routing OR hash routing. It'd be nice if we could resolve these in addition to normal paths.
E.g. these paths can be problematic:
/foo/bar#baz
/foo/bar
and/#hey
Paths could then be represented reflecting the actual values in the url bar, removing the need for
hash.js
and remove the need for chunky switching logic.Possibly separate issue:
We're also not resolving query strings at the moment, perhaps we should add them in params too? Or pass in an extra object containing querystrings as an object? idk
The text was updated successfully, but these errors were encountered: