Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle hashes by default, in addition to normal paths #31

Closed
yoshuawuyts opened this issue Jul 20, 2016 · 3 comments
Closed

Handle hashes by default, in addition to normal paths #31

yoshuawuyts opened this issue Jul 20, 2016 · 3 comments

Comments

@yoshuawuyts
Copy link
Owner

Right now there's trouble in hash land. When resolving routes it's either normal routing OR hash routing. It'd be nice if we could resolve these in addition to normal paths.

E.g. these paths can be problematic:

  • /foo/bar#baz
  • /foo/bar and /#hey

Paths could then be represented reflecting the actual values in the url bar, removing the need for hash.js and remove the need for chunky switching logic.

Possibly separate issue:

We're also not resolving query strings at the moment, perhaps we should add them in params too? Or pass in an extra object containing querystrings as an object? idk

@timwis
Copy link
Contributor

timwis commented Jul 20, 2016

+1 for query strings, was just thinking about that

@yoshuawuyts
Copy link
Owner Author

yoshuawuyts commented Jul 20, 2016

We're also not resolving query strings at the moment, perhaps we should add them in params too? Or pass in an extra object containing querystrings as an object? idk

Imo this shouldn't ever impact the routing - if query strings need to be resolved this could be done in a separate function. Perhaps we should provide that - I reckon the node querystring package is too big to include so find a separate solution.

edit: for choo we could then have in addition to state.params a state.querystrings or state.qs value

@yoshuawuyts
Copy link
Owner Author

landed in sheet-router@4 somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants