-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(http): remove #269
feat(http): remove #269
Conversation
6a2f171
to
a9eb972
Compare
Yea. I thought for this too. Because I was playing with % ❯ ls -al dist October 08, 03:03:49
total 384K
drwxr-xr-x 2 charlike users 4.0K Oct 5 05:12 ./
drwxr-xr-x 4 charlike users 4.0K Oct 5 05:17 ../
-rw-r--r-- 1 charlike users 152 Oct 5 05:17 200.html
-rw-r--r-- 1 charlike users 273K Oct 5 05:17 bundle.js
-rw-r--r-- 1 charlike users 38K Oct 5 05:17 bundle.min.js
-rw-r--r-- 1 charlike users 56K Oct 5 05:17 bundle.min.js.map with And it's not only because the |
@tunnckoCore you might want to consider running gzip and other optimizations: |
a9eb972
to
f12f843
Compare
everyone seems to be ok with this, merging! |
* location: change url on location:setLocation - [ ] don't break hashing - [ ] allow not changing the url fixup! move fns around fixup! add search string * app.start: clean * walk: add * location: update arg calls * fixup! location: update * uri-wrap: fix thunking * router: update to latest sheet-router (#239) * router: update to latest sheet-router * tests: fix for latest version * tests: fix SSR * tests: fix history * tests: spruce up * docs: update example * examples: update * deps: bump sheet-router * 4.0.0-0 * chore(changelog): 4.0.0 (#211) * feat(api:) arg order (#268) * s/data, state/state, data/ * feat(api): swap arguments * fix(href): fix routing (#271) * feat(http): remove (#269) * feat(router): enable hash routing (#273) * deps: fix mount * 4.0.0-1 * feat(mount): copy {script,link} tags * 4.0.0-2 * fix(mount): forEach -> for Lol can't use forEach * fix(router): use state.location.href (#282) * fix(mount): use deep node clone * 4.0.0-3 * fix(deps): remove hash-match * 4.0.0-4 * fix(mount): return node * 4.0.0-5 * fix(router): check if a hash is a valid selector (#339) * 4.0.0-6 * fix(router): pass params on newstate (#343) * 4.0.0-7 * feat(docs): update for 4.0.0 (#320) * feat(docs): update for 4.0.0 * docs: update router example in readme (#337) * chore(changelog): update for v4 (#351)
Removes
choo/http
. In previous IRC conversations we kind of came to the conclusion that this doesn't make a lot of sense to bundle in anymore given that a lot of choo's narrative is now about how to glue views, logic and state. We weren't mentioning it anywhere in the README anymore anyway, so it might make sense to deprecate in its entirety.Having thoughts on this would be highly welcome! - Thanks!