Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArgoCD version to v2.7.10 #653

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fix ArgoCD version to v2.7.10 #653

merged 2 commits into from
Oct 24, 2023

Conversation

krapie
Copy link
Member

@krapie krapie commented Oct 23, 2023

What this PR does / why we need it:

Fix ArgoCD version to v2.7.10.

This is to prevent unexpected ArgoCD system failure on version upgrades.
For more information, follow: argoproj/argo-cd#15220

Which issue(s) this PR fixes:

Fixes https://github.com/yorkie-team/devops/issues/60

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@krapie krapie requested a review from hackerwins October 23, 2023 07:48
@krapie krapie self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37ef0ea) 48.86% compared to head (c52b6e3) 48.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #653   +/-   ##
=======================================
  Coverage   48.86%   48.86%           
=======================================
  Files          69       69           
  Lines       10082    10082           
=======================================
  Hits         4927     4927           
  Misses       4635     4635           
  Partials      520      520           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins
Copy link
Member

@krapie Can you change the status of this PR to Ready?

@krapie
Copy link
Member Author

krapie commented Oct 23, 2023

I need to check if this configuration works fine on other cluster. It will take some time.

@hackerwins hackerwins removed their request for review October 23, 2023 08:02
@krapie krapie marked this pull request as ready for review October 24, 2023 06:32
@krapie krapie requested a review from hackerwins October 24, 2023 06:32
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 023cd4b into main Oct 24, 2023
1 check passed
@hackerwins hackerwins deleted the fix-argocd-version branch October 24, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants