-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI workflow doesn't work due to Docker Compose V1 being deprecated on the runner's ubuntu image #949
Comments
Is this issue occurring every time we perform |
In Github Actions, yes. Elsewhere, Compose V1 will work, but Docker compose V1 has been deprecated since 2021, so it's probably best to move to Compose V2 in most cases. The only place I've found that uses docker-compose is the ci.yaml in yorkie-js-sdk |
Some of the documentation points to using docker-compose, do we need to change that? |
@kokodak Yes. I think it is time to update everything to docker compose V2. |
In #950 PR, the main CONTRIBUTING.md and docker README.md files were modified. Is there anything else that needs to be modified? |
@fourjae I think yorkie repository is up to date. I have checked the occurrence of the word |
I will work on the Compose V1 issue in the yorkie-js-sdk repository. |
@krapie |
What happened:
Since this PR, docker compose V1 no longer works with ubuntu images in the actions runner.
For this reason, there is currently an issue with CI workflow not working properly.
What you expected to happen:
The CI workflow should work correctly.
How to reproduce it (as minimally and precisely as possible):
Refer to the Docker documentation for Migrate Compose V2, replacing the commands in compose V1 with the commands in compose V2.
Anything else we need to know?:
This issue can occur in multiple repositories within yorkie-team, not just the yorkie repository.
Environment:
yorkie version
): v0.4.28The text was updated successfully, but these errors were encountered: