Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflow doesn't work due to Docker Compose V1 being deprecated on the runner's ubuntu image #949

Closed
kokodak opened this issue Aug 3, 2024 · 8 comments · Fixed by #950
Assignees
Labels
bug 🐞 Something isn't working

Comments

@kokodak
Copy link
Member

kokodak commented Aug 3, 2024

What happened:

Since this PR, docker compose V1 no longer works with ubuntu images in the actions runner.
For this reason, there is currently an issue with CI workflow not working properly.

image

What you expected to happen:

The CI workflow should work correctly.

How to reproduce it (as minimally and precisely as possible):

Refer to the Docker documentation for Migrate Compose V2, replacing the commands in compose V1 with the commands in compose V2.

Anything else we need to know?:

This issue can occur in multiple repositories within yorkie-team, not just the yorkie repository.

Environment:

  • Operating system:
  • Browser and version:
  • Yorkie version (use yorkie version): v0.4.28
  • Yorkie JS SDK version:
@kokodak kokodak added the bug 🐞 Something isn't working label Aug 3, 2024
@kokodak kokodak changed the title CI workflow doesn't work due to Docker Compose V1 being deprecated on the Actions runner's ubuntu image CI workflow doesn't work due to Docker Compose V1 being deprecated on the runner's ubuntu image Aug 3, 2024
@krapie
Copy link
Member

krapie commented Aug 3, 2024

Is this issue occurring every time we perform docker-compose command on Github Actions?
I think we need to find which repositories are using docker-compose command and make a checklist below to track it.

@kokodak
Copy link
Member Author

kokodak commented Aug 3, 2024

Is this issue occurring every time we perform docker-compose command on Github Actions? I think we need to find which repositories are using docker-compose command and make a checklist below to track it.

In Github Actions, yes.

Elsewhere, Compose V1 will work, but Docker compose V1 has been deprecated since 2021, so it's probably best to move to Compose V2 in most cases.

The only place I've found that uses docker-compose is the ci.yaml in yorkie-js-sdk

@kokodak
Copy link
Member Author

kokodak commented Aug 3, 2024

Some of the documentation points to using docker-compose, do we need to change that?

@krapie
Copy link
Member

krapie commented Aug 3, 2024

@kokodak Yes. I think it is time to update everything to docker compose V2.

@fourjae
Copy link
Contributor

fourjae commented Aug 3, 2024

In #950 PR, the main CONTRIBUTING.md and docker README.md files were modified. Is there anything else that needs to be modified?

@krapie
Copy link
Member

krapie commented Aug 3, 2024

@fourjae I think yorkie repository is up to date. I have checked the occurrence of the word docker-compose -f.
Could you re-check it to see if there are anything that we have omitted?

@kokodak
Copy link
Member Author

kokodak commented Aug 3, 2024

I will work on the Compose V1 issue in the yorkie-js-sdk repository.

@fourjae
Copy link
Contributor

fourjae commented Aug 3, 2024

@krapie
I think the docker-compose -f command no longer exists in all files of the yorkie server project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants