Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GetDocuments API request specification in CodePair to match recent changes in Admin Server #240

Closed
kokodak opened this issue Jul 20, 2024 · 2 comments · Fixed by #242
Assignees

Comments

@kokodak
Copy link
Member

kokodak commented Jul 20, 2024

Description:

Recently, the request specification for the GetDocuments API in Admin Server has changed through this PR.

As a result, the parts of CodePair that utilize the GetDocuments API need to be updated to align with the new API request specification.

async findManyFromYorkie(
documentKeyList: Array<string>
): Promise<FindDocumentsFromYorkieResponse | undefined> {
return new Promise((resolve, reject) => {
const client = connect(`${this.configService.get<string>("YORKIE_API_ADDR")}`);
client.on("error", (err) => reject(err));
const requestBody = JSON.stringify({
project_name: this.configService.get<string>("YORKIE_PROJECT_NAME"),
document_keys: documentKeyList,
});

Why:

To ensure seamless integration between CodePair and Admin Server after the recent change in the API request specification. This enhancement is crucial to maintain the functionality of CodePair.

@devleejb
Copy link
Member

@kokodak
If you want to resolve this issue, please tell me.
I will assign you.

@kokodak
Copy link
Member Author

kokodak commented Jul 20, 2024

@kokodak If you want to resolve this issue, please tell me. I will assign you.

I want to resolve it. Could I try it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants