-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown in ReadmePreview not parsed correctly #48
Comments
Will this also fix #23 ? |
Sounds good! Could you submit a PR which uses marked instead of showdown and we'll see if it works better? @shacharRonZohar |
@eylonxx possibly, although I suspect we will need to add a further emoji parsing layer, since I doubt that marked or any library will keep a collection of all possible emojis themselves.
@yonatanmgr for sure! I'll work on it today and see if it solves it |
Resloved in #49 |
Since the markdown is taken as a string and parsed as regular html, it misses some important parts from GitHub readme markdown presentation.
Consider this title part of a readme preview, that currently looks like this:
While the actual readme looks like this:
I prototyped a solution using marked, which allows us to parse and render the correct HTML quickly and without implementing our own parser, and would love to submit a PR if there is interest in using this particular library, or any other.
The text was updated successfully, but these errors were encountered: