[bug fix] Ensure fileTypes are mapped to JSON value #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sure thing! Added! |
yonaskolb
approved these changes
Aug 2, 2021
|
@yonaskolb do you have any estimates on when you think the next release may go out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After finding out that #1111 was already possible via
xcodegen dump, I tried it out for my project, but noticed that there was an error for my project when trying to use theparsed-yamlor theparsed-jsonoptions. It turns out there was a JSON/Yaml serialization error due tofileTypesstill being the raw Swift type vs the JSON value.