Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deinflection of -そう for よい and ない is wrong #1689

Open
unectomy opened this issue Dec 22, 2024 · 2 comments
Open

Deinflection of -そう for よい and ない is wrong #1689

unectomy opened this issue Dec 22, 2024 · 2 comments
Labels
kind/enhancement The issue or PR is a new feature or request

Comments

@unectomy
Copy link

The proper inflections for よい and ない when they have the そう suffix are よさそう and なさそう, respectively. However, when you scan these two inflected words, you don't get deinflections like よい 🧩-そう and ない 🧩-そう (compare them to 美味しそう).

Meanwhile, if you scan なそう and よそう, you do get the deinflections written above even though these inflections are wrong.

I think that the deinflections should be fixed and that the popup (when you click on -そう) should state that these two adjectives are irregular.

@unectomy unectomy added the kind/enhancement The issue or PR is a new feature or request label Dec 22, 2024
@khaitruong922
Copy link

khaitruong922 commented Dec 22, 2024

The current deinflection logic does not prevent conjugate irregular verb in regular way, so it is impossible to fix なそう and よそう unless we rework the logic.

For ない it will have 2 ways to implement but both have drawbacks

  • Suffix inflection ない -> なさそう: will affect adjectives end with ない, for example: 危ない -> 危なさそう (wrong)
  • Whole word inflection for the term ない only: won't inflect terms like 間違いない、問題ない。

無いー>無さそう could be implemented as suffix inflection.

よい and technically all forms of it (良い/善い/好い/吉い/佳い) could be implemented as suffix inflection, but from the number of Google results, only よさそう、良さそう,好さそう are common enough.

Any idea or feedback is welcome.

@Casheeew
Copy link
Member

Perhaps dictionary inflection would be useful for once for Japanese?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

No branches or pull requests

3 participants