Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PR should have automatically assigned Ynteam active project #22

Closed
2 tasks done
jakubjezek001 opened this issue Sep 26, 2024 · 5 comments
Closed
2 tasks done
Assignees
Labels
feature Additional functionality which doesn't exist yet

Comments

@jakubjezek001
Copy link
Member

jakubjezek001 commented Sep 26, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

Currrently every new PR has to have manually assigned Ynteam active project

How would you imagine the implementation of the feature?

It would be awesome if avery new PR would be automatically have assigned Ynteam Planning project.

Are there any labels you wish to add?

  • I have added the relevant labels to the feature request.

Describe alternatives you've considered:

No response

Additional context:

No response

@jakubjezek001 jakubjezek001 added the feature Additional functionality which doesn't exist yet label Sep 26, 2024
@philnewm
Copy link
Collaborator

Thats good stuff 👍
The idea itself is pretty easy to implement since github provides a bunch of built in event triggers like one for pull requests

on:
  pull_request:
    types:
      - opened
    paths:
      - '.github/workflows/**'
      - '.github/CODEOWNERS'
      - 'package*.json'

The bigger challenge here is to implement a standardized approach for all intended repositories.
Cause mainting such globally wnated workflows on a per repo basis is simply pointless.

So I see too options here

  • Implement a workflow which can create PRs for multiple repos at once to suggest workflow updates
  • Implement workflows on organization level so hopefully all repos can just inherit them

@jakubjezek001
Copy link
Member Author

Good questions. Let's first assume that it is something we want to be automated - and I am assuming there is no reason we do not, right @dee-ynput ?

I believe this should be organization wide workflow and only purpose is to simply attach Ynput Active project to a PR, in case a PR is assigned to anyone (trigger).

@jakubjezek001 jakubjezek001 changed the title New PR should have automatically assigned Ynteam planning project New PR should have automatically assigned Ynteam active project Oct 1, 2024
@mkolar mkolar removed the feature Additional functionality which doesn't exist yet label Oct 30, 2024
@mkolar
Copy link
Member

mkolar commented Oct 30, 2024

Definitelly and org wide workflow

@mkolar mkolar added feature Additional functionality which doesn't exist yet and removed feature Additional functionality which doesn't exist yet labels Oct 30, 2024
@philnewm philnewm added the feature Additional functionality which doesn't exist yet label Nov 11, 2024
@philnewm philnewm self-assigned this Nov 11, 2024
@philnewm
Copy link
Collaborator

I tested this now with ayon-maya and it does already work for all newly created prs

@jakubjezek001 should the status be set to anything or is "No status" fine as long as the PR is assigned to the project?

@philnewm
Copy link
Collaborator

This is now implemented and pushed to all addon repos bb9327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Additional functionality which doesn't exist yet
Projects
None yet
Development

No branches or pull requests

3 participants