Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Hub: Refactor get children to work with added entity types support #198

Open
2 tasks done
iLLiCiTiT opened this issue Oct 28, 2024 · 0 comments
Open
2 tasks done
Assignees
Labels
type: enhancement New feature or request

Comments

@iLLiCiTiT
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

Current implementation of childrens logic in EntityHub works only for folders and tasks, that does not include products and versions.

How would you imagine the implementation of the feature?

First of all it should be possible to get children of products.

Second issue is that it should be possible to get products as children of folders, but becuase the current logic counts only with folders it is not that easy. When currently available methods are called we should also fetch products with other folders and tasks. But we should add more targetted methods to get only folders, or only products or only tasks, and fetch them and cache their entities respectivelly, so when folder already has known folder entities, but get_children is called we should also look for tasks and products.

Another question is if tasks should option to have version entities as children, because the connection is there we might add it.

Are there any labels you wish to add?

  • I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

No response

Additional context:

No response

@iLLiCiTiT iLLiCiTiT added the type: enhancement New feature or request label Oct 28, 2024
@iLLiCiTiT iLLiCiTiT self-assigned this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant