Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute definitions: Fix context menu on sequence items #1033

Merged

Conversation

MustafaJafar
Copy link
Contributor

@MustafaJafar MustafaJafar commented Nov 29, 2024

Changelog Description

Fix issue with sequence item context menu button in FileDef widget.

Testing notes:

  1. Add a FileDef allowing sequences to any plugin.
  2. Drop into the widget sequence.
  3. Click this icon, A menu should show up as expected (with Split sequence action).
    Image

Resolves #1032 .

@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Nov 29, 2024
@ynbot ynbot added size/XS type: bug Something isn't working labels Nov 29, 2024
@iLLiCiTiT
Copy link
Member

It looks like this is getting rid of an error, but does not really fix the issue.

@MustafaJafar
Copy link
Contributor Author

It looks like this is getting rid of an error, but does not really fix the issue.

Yes, I think the error and the issue were two separate things.

@iLLiCiTiT iLLiCiTiT self-assigned this Dec 10, 2024
@iLLiCiTiT iLLiCiTiT requested review from kalisp, 64qam and MilaKudr and removed request for iLLiCiTiT December 10, 2024 14:19
@iLLiCiTiT iLLiCiTiT changed the title Add missing argument to context_menu_requested signal Attribute definitions: Fix context menu on sequence items Dec 10, 2024
@iLLiCiTiT iLLiCiTiT removed the community Issues and PRs coming from the community members label Dec 10, 2024
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iLLiCiTiT iLLiCiTiT merged commit 120eddd into develop Dec 10, 2024
9 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/1032-filedef-doesnt-work-properly-in-houdini branch December 10, 2024 14:56
@vivimage
Copy link

This pull request doesn't solve the original issue

Screen_Recording_2024-11-29_185248.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileDef doesn't work properly
5 participants