Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert that decopying isn't needed here. #1452

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

ltratt
Copy link
Contributor

@ltratt ltratt commented Nov 4, 2024

This is belt and braces, because I'm about 99.9% sure that this condition can never be violated, but were it to be, all sorts of hard-to-debug things would occur.

This is belt and braces, because I'm about 99.9% sure that this
condition can never be violated, but were it to be, all sorts of
hard-to-debug things would occur.
@vext01
Copy link
Contributor

vext01 commented Nov 4, 2024

I'm happy with this. I just need to debug what's currently blocking CI.

@ltratt
Copy link
Contributor Author

ltratt commented Nov 4, 2024

FWIW, yk's CI isn't blocked, so you can merge this PR if you want.

@vext01 vext01 added this pull request to the merge queue Nov 4, 2024
Merged via the queue into ykjit:master with commit e328f0c Nov 4, 2024
2 checks passed
@ltratt ltratt deleted the assert_decopy branch November 19, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants