Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all promotions are always consumed #1455

Open
ltratt opened this issue Nov 4, 2024 · 0 comments
Open

Not all promotions are always consumed #1455

ltratt opened this issue Nov 4, 2024 · 0 comments
Assignees

Comments

@ltratt
Copy link
Contributor

ltratt commented Nov 4, 2024

In #1454 I added an assert to check that all promotions are consumed by trace_builder: but they aren't! gc.lua fails:

16:49:40 .thread '<unnamed>' panicked at ykrt/src/compile/jitc_yk/trace_builder.rs:1299:9:
16:49:40 assertion `left == right` failed
16:49:40 left: 48
16:49:40 right: 60
16:49:40 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
16:49:40 thread '<unnamed>' panicked at ykrt/src/mt.rs:337:46:

i.e. after building the trace, 12 bytes of promotion data were unconsumed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants