Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yksmp::Location::Constant should be limited to trace_builder #1435

Open
ltratt opened this issue Oct 24, 2024 · 0 comments
Open

yksmp::Location::Constant should be limited to trace_builder #1435

ltratt opened this issue Oct 24, 2024 · 0 comments
Assignees

Comments

@ltratt
Copy link
Contributor

ltratt commented Oct 24, 2024

We can (mostly as a result of optimisations + side traces) end up with JIT IR like this (a real example):

%50: i1 = load_ti Constant(1)

I thought I could get trace_builder to convert this straight away to:

%50: i1 = Const(1)

but if I do that, things go wrong. I guess this is because "tilocs" are a fixed number of things, and you can't intersperse Inst::Const with them. At least in my particular case I can hack around this in the optimiser, but that might only be a short-term fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants