Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parsing of updated load_ti instructions. #1319

Open
ptersilie opened this issue Jul 25, 2024 · 0 comments
Open

Allow parsing of updated load_ti instructions. #1319

ptersilie opened this issue Jul 25, 2024 · 0 comments
Assignees

Comments

@ptersilie
Copy link
Contributor

#1318 changes the representation of the load_ti instruction from load_ti <offset> to load_ti <VarLocationIdx>. Printing such an instruction results in output like load_ti VarLocation::Register(GP(RAX)). This change, however, hasn't been applied to the JIT IR parser yet. I've worked around this by cheating a bit: the parser still parses load_ti <usize> and then just makes up a VarLocation (always GP(RBX))).

Unfortunately, this means that the input and ouput of the JIT IR parser no longer match, and thus we had to change some tests and disable the roundtrip test. A proper solution for this would be to update the JIT IR parser to be able to parse load_ti instructions such as load_ti Register(GP(RAX)) or load_ti Direct(off, size) or load_ti Indirect(off, size), etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants