Call add_html_caption() with two arguments instead of three in Quarto
#2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderv
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Yes I believe so. Old quarto redefines
add_html_caption <- function(options, x) {
if (inherits(x, 'knit_asis_htmlwidget')) {
and new quarto like this
add_html_caption <- function(options, x, ...) {
if (inherits(x, 'knit_asis_htmlwidget')) {
So I believe this PR will make it work for old (1.2 and before) and newer (1.3 and later).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2261.
@cderv Do you think this would be a reasonable fix?