Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace several stringr fns with base equivalents #2205

Merged
merged 18 commits into from
Dec 22, 2022
Merged

Replace several stringr fns with base equivalents #2205

merged 18 commits into from
Dec 22, 2022

Commits on Dec 22, 2022

  1. Add adaptations of several stringr fns

    @rich-iannone
    rich-iannone committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    0732641 View commit details
    Browse the repository at this point in the history

  2. Replace uses of str_extract_all()

    @rich-iannone
    rich-iannone committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    13ba951 View commit details
    Browse the repository at this point in the history

  3. Replace uses of str_locate_all()

    @rich-iannone
    rich-iannone committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    bf9a82c View commit details
    Browse the repository at this point in the history

  4. Replace uses of str_locate()

    @rich-iannone
    rich-iannone committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    174f5f4 View commit details
    Browse the repository at this point in the history

  5. Add initial implementation of str_match_all() replacement

    @rich-iannone
    rich-iannone committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    c165917 View commit details
    Browse the repository at this point in the history

  6. Specially handle no-match case

    @rich-iannone
    rich-iannone committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    7de5d52 View commit details
    Browse the repository at this point in the history

  7. Remove unneeded function

    @rich-iannone
    rich-iannone committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    03369fb View commit details
    Browse the repository at this point in the history

  8. Replace use of str_match_all() with base equivalent

    @rich-iannone
    rich-iannone committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    0f8e7be View commit details
    Browse the repository at this point in the history

  9. Adapt gregexpr() to custom grepexec_knitr() fn

    @rich-iannone
    rich-iannone committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    260509c View commit details
    Browse the repository at this point in the history

  10. Remove stringr package from Imports

    @rich-iannone
    rich-iannone committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    127aae6 View commit details
    Browse the repository at this point in the history

  11. Replace use of str_locate() with base equivalent

    @rich-iannone
    rich-iannone committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    24f2b04 View commit details
    Browse the repository at this point in the history

  12. Merged origin/master into stringr-fn-replacement

    @yihui
    yihui committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    6d8f8be View commit details
    Browse the repository at this point in the history

  13. see if location() can be simplified (i.e., do we really need cbind(NA… 

    …, NA)?)
    @yihui
    yihui committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    ab41b47 View commit details
    Browse the repository at this point in the history

  14. merge str_single_locate() and str_complete_locate()

    @yihui
    yihui committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    30febbd View commit details
    Browse the repository at this point in the history

  15. rename str_complete_extract() to str_extract(), and use gregexpr() + … 

    …regmatches() instead
    @yihui
    yihui committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    7e121e0 View commit details
    Browse the repository at this point in the history

  16. simplify str_get_all_matches() and avoid copying code from base R

    @yihui
    yihui committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    4fe4338 View commit details
    Browse the repository at this point in the history

  17. rename string -> x [ci skip]

    @yihui
    yihui committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    f4c3a83 View commit details
    Browse the repository at this point in the history

  18. add news [ci skip]

    @yihui
    yihui committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    1a89f09 View commit details
    Browse the repository at this point in the history